Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

**Fix:** Adjust context menu's overlay z-index to cover everything #927

Merged
merged 1 commit into from
Feb 21, 2019
Merged

**Fix:** Adjust context menu's overlay z-index to cover everything #927

merged 1 commit into from
Feb 21, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Feb 20, 2019

Summary

This PR fixes the z-index of the InvisibleOverlay for ContextMenu to properly cover everything.

To be tested

Me

  • No error or warning in the console on localhost:6060

Tester 1

  • Things look good on the demo.

Tester 2

  • Things look good on the demo.

@TejasQ TejasQ self-assigned this Feb 20, 2019
@TejasQ TejasQ requested a review from fabien0102 February 20, 2019 18:44
@TejasQ TejasQ merged commit ab33530 into master Feb 21, 2019
@TejasQ TejasQ deleted the PLAT-10-dancing-cards branch February 21, 2019 09:48
@TejasQ TejasQ mentioned this pull request Feb 22, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stereobooster stereobooster stereobooster approved these changes

@fabien0102 fabien0102 Awaiting requested review from fabien0102

Assignees

@TejasQ TejasQ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejasQ @stereobooster