**Fix:** Autocomplete z-index #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejasQ
changed the title
TejasQ
force-pushed
the
fix/autocomplete-z-index
branch
from
98bb04a to
8333d85
Compare
TejasQ
changed the title
|
UPD it doesn't happen in isolated mode of styleguidist |
stereobooster
approved these changes
Feb 22, 2019
|
what else do we need to test except autocomplete? |
|
Nothing else needs to be tested :) |
|
Also @stereobooster, #935 (comment) <- is this still valid? I don't see it on styleguidist. You should definitely not approve this if that's the case. 😉 |
|
Not in isolated mode. |
fabien0102
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #934, removing a useless z-index override from
Autocompleteand using the correct z-index thatContextMenugot in #927.Here is the clickable area on Autocompletes now:
To be tested
Me
localhost:6060Tester 1
Tester 2