Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close sidebar when opening full screen #3360

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

HD787
Copy link
Contributor

@HD787 HD787 commented Dec 13, 2024

Description

the sidebar will now close when the full screen is opened, trying to open it while full screen is up will take you to fullscreen, it will reopen when the fullscreen is closed.

Testing

tested on vscode

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 8d37e36
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/675c8516113d5c0008df0e8f

@HD787 HD787 marked this pull request as draft December 13, 2024 19:19
@HD787 HD787 marked this pull request as ready for review December 13, 2024 19:28
@HD787
Copy link
Contributor Author

HD787 commented Dec 13, 2024

is there any interest in making the sidebar reopen to the current session?

@sestinj sestinj merged commit c346458 into continuedev:main Dec 13, 2024
14 checks passed
@HD787 HD787 deleted the closeSidebar branch December 13, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants