refactor: Adjust inlay rendering and improve completion logic #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `ContinueCustomElementRenderer` and `ContinueMultilineCustomElementRenderer` with `ContinueInlayRenderer`. - Add `Editor.addInlayElement` to handle inline and block inlay elements. - Refactor `AutocompleteService` to use new inlay renderer and improve completion rendering conditions. - Update `AcceptAutocompleteAction` to match new changes.
✅ Deploy Preview for continuedev canceled.
|
sestinj
reviewed
Dec 24, 2024
| val column = editor.caretModel.primaryCaret.logicalPosition.column | ||
| val input = mapOf( | ||
| "completionId" to completionId, | ||
| "filepath" to virtualFile?.url, | ||
| "filepath" to virtualFile?.path, |
There was a problem hiding this comment.
(was this the solution to a clear problem?)
There was a problem hiding this comment.
I was just about to comment on it. I didn't pay attention to #3247, need to revert it here.
Because using File(URI(filepath)) will cause an error in Windows, I made temporary changes locally and submitted this by mistake.
There was a problem hiding this comment.
Uh, maybe it's better to fix it than revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Testing