Fix macOS specific key handling #1614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
VT: Backend
Signed-off-by: Christian Parpart <christian@parpart.family>
christianparpart
force-pushed
the
fix/arrow_word_navigation_macos
branch
from
bcb58f5
to
2238d5b
Compare
| // Use option key as a control modifier to use | ||
| // Ctrl-Left[Right]Arrow for word navigation. | ||
| if (modifier == Modifier::Alt) | ||
| return 1 + Modifier::Control; |
There was a problem hiding this comment.
@Yaraslaut i've force-pushed my suggestion right into the PR.
The change is to use symbolic names in order to make it more intuitive to read, also with the line (1 + value) below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes macOS specific handling of the input