Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS specific key handling #1614

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix macOS specific key handling #1614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vtbackend/InputGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ using Modifiers = crispy::flags<Modifier>;
/// @returns CSI parameter for given function key modifier
constexpr size_t makeVirtualTerminalParam(Modifiers modifier) noexcept
{
#if defined(__APPLE__)
// Use option key as a control modifier to use
// Ctrl-Left[Right]Arrow for word navigation.
if (modifier == Modifier::Alt)
return 1 + Modifier::Control;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yaraslaut i've force-pushed my suggestion right into the PR.

The change is to use symbolic names in order to make it more intuitive to read, also with the line (1 + value) below.

#endif
return 1 + modifier.value();
}

Expand Down
Loading