Add example using the instructions array for a state RPC #84 #2501

lastemp · 2023-05-22T09:46:54Z

This is an example program for using the instructions array for a state RPC.

It is meant to close issue "example using the instructions array for a state RPC #84"

vercel · 2023-05-22T09:46:58Z

@lastemp is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

acheroncrypto

How long have you been waiting for this PR?

This PR:

Adds an example to a deprecated method,
Uses wrong NPM package(@project-serum/anchor is outdated),
Uses outdated anchor-lang version(0.26.0 instead of using a local path like other examples),
Has a bunch of files that are not necessary and doesn't exist in other examples,
Has unformatted code,
Wallet path starts with the author's home path instead of ~.

Please check the other examples before adding another example.

examples/tutorial/basic-5/.gitignore

examples/tutorial/basic-5/.prettierignore

examples/tutorial/basic-5/Anchor.toml

examples/tutorial/basic-5/tests/basic-5.ts

examples/tutorial/basic-5/tsconfig.json

examples/tutorial/basic-5/yarn.lock

examples/tutorial/basic-5/programs/basic-5/src/lib.rs

lastemp · 2023-05-22T15:06:59Z

@acheroncrypto @Aursen I am really thankful for the time and effort you put in to review my work. Please note that I have worked on the issues you raised.

acheroncrypto

It looks much better now, thank you for updating.

examples/tutorial/basic-5/README.md

examples/tutorial/basic-5/programs/basic-5/src/lib.rs

examples/tutorial/basic-5/tests/basic-5.ts

examples/tutorial/basic-5/Anchor.toml

examples/tutorial/basic-5/programs/basic-5/src/lib.rs

examples/tutorial/basic-5/tests/basic-5.ts

acheroncrypto · 2023-05-23T14:02:23Z

@lastemp Thank you for addressing the problems, have you tested this and confirmed it works?

lastemp · 2023-05-23T15:11:02Z

@lastemp Thank you for addressing the problems, have you tested this and confirmed it works?
Yes, I did my tests on local cluster and it worked. Please find the attached screenshot.

acheroncrypto · 2023-05-23T15:54:56Z

@lastemp Thank you for addressing the problems, have you tested this and confirmed it works?
Yes, I did my tests on local cluster and it worked. Please find the attached screenshot.

I don't think we have TypeScript installed in tutorials workspace and all other tutorials are using JavaScript. It might work for you if you have every dependency globally installed via npm but it won't work for other people.

Could you specify the necessary dev dependencies(typescript, ts-mocha...) in https://github.com/coral-xyz/anchor/blob/master/examples/tutorial/package.json#L18 ?

lastemp · 2023-05-24T09:45:23Z

@lastemp Thank you for addressing the problems, have you tested this and confirmed it works?
Yes, I did my tests on local cluster and it worked. Please find the attached screenshot.

I don't think we have TypeScript installed in tutorials workspace and all other tutorials are using JavaScript. It might work for you if you have every dependency globally installed via npm but it won't work for other people.

Could you specify the necessary dev dependencies(typescript, ts-mocha...) in https://github.com/coral-xyz/anchor/blob/master/examples/tutorial/package.json#L18 ?

Thanks for the guidance, please note that I have now added the dev dependencies.

acheroncrypto

Thank you for your contribution. I don't think we need to add this to CI, so I'm merging it as is.

lastemp · 2023-05-24T12:17:35Z

Thank you for your contribution. I don't think we need to add this to CI, so I'm merging it as is.

@acheroncrypto @Aursen I am so thankful and grateful for the valuable input you both provided.

commit e1afcbf Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Fri Jun 9 18:00:35 2023 +0200 v0.28.0 (coral-xyz#2527) commit c7c7319 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Thu Jun 8 18:59:44 2023 +0200 Allow wider range of dependency versions to reduce dependency issues (coral-xyz#2524) commit 6df34e7 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Wed Jun 7 19:12:56 2023 +0200 Update crate authors and remove outdated registry (coral-xyz#2522) commit 1705d16 Author: Jean Marchand (Exotic Markets) <jeanno11@orange.fr> Date: Wed Jun 7 16:29:23 2023 +0200 docs: Add doc for InitSpace macro (coral-xyz#2521) commit 3d7c97b Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Tue Jun 6 19:28:24 2023 +0200 cli: Accept program lib name for `anchor deploy --program-name` (coral-xyz#2519) commit a88be42 Author: Sergo <rogaldh@radsh.red> Date: Tue Jun 6 14:07:33 2023 +0300 ts: Validate `error.data` exists on simulation response (coral-xyz#2508) commit 65c9d6e Author: Jean Marchand (Exotic Markets) <jeanno11@orange.fr> Date: Tue Jun 6 09:43:46 2023 +0200 client: Add async to anchor-client (coral-xyz#2488) Co-authored-by: acheron <acheroncrypto@gmail.com> commit b8eda69 Author: Deep Mehta <65382963+0xdeepmehta@users.noreply.github.com> Date: Mon Jun 5 22:35:24 2023 +0530 cli: Print not found message if the given program cannot be found during deployment (coral-xyz#2517) commit 1902b8e Author: CanardMandarin <thibault.marboud@gmail.com> Date: Mon Jun 5 14:16:10 2023 +0200 cli: Update programs in `Anchor.toml` when using `anchor new` (coral-xyz#2516) commit 383e440 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Sun Jun 4 21:02:16 2023 +0200 cli: Initialize with the correct program id (coral-xyz#2509) commit 835dc5b Author: Sarfaraz Nawaz <sir_nawaz959@yahoo.com> Date: Sun Jun 4 23:20:03 2023 +0530 lang: Rename derive_anchor_deserialize -> derive_init_space (coral-xyz#2510) commit 1c6f86e Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Sun Jun 4 13:09:39 2023 +0200 Upgrade Solana to 1.16.0 (coral-xyz#2512) commit 2bf8afe Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Tue May 30 19:50:45 2023 +0200 cli: Use `confirmed` commitment level in commands (coral-xyz#2506) commit 70d9223 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Sun May 28 22:34:53 2023 +0200 cli: Add `anchor keys sync` command (coral-xyz#2505) commit 0c8498d Author: cavemanloverboy <93507302+cavemanloverboy@users.noreply.github.com> Date: Sat May 27 06:53:02 2023 -0700 cli: Exit `anchor clean` without error when dirs don't exist (coral-xyz#2504) commit 23b90bf Author: Noah Gundotra <ngundotra@users.noreply.github.com> Date: Fri May 26 12:36:46 2023 -0400 Feature: CPI Events API (coral-xyz#2438) Co-authored-by: acheron <acheroncrypto@gmail.com> commit c3625c8 Author: Last Emperor <46998219+lastemp@users.noreply.github.com> Date: Wed May 24 15:05:47 2023 +0300 examples: Add an example with `instruction` method (coral-xyz#2501) Co-authored-by: acheron <acheroncrypto@gmail.com> commit 67eb752 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Sat May 20 20:34:38 2023 +0200 tests: Fix zero-copy tests (coral-xyz#2498) commit f9d0eca Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Fri May 19 13:18:14 2023 +0200 spl: Update `spl-token-2022` to 0.6.1 (coral-xyz#2496) commit 4793b90 Author: acheron <98934430+acheroncrypto@users.noreply.github.com> Date: Fri May 19 10:58:16 2023 +0200 Fix `toml_datetime` 1.64.0 MSRV error (coral-xyz#2495) commit 41a4d82 Author: chalda <chalda@seznam.cz> Date: Thu May 18 19:12:25 2023 +0200 cli: Add print base64 instruction option for some of the IDL commands (coral-xyz#2486) Co-authored-by: acheron <acheroncrypto@gmail.com> commit b7bada1 Author: Pierre <Arrowana@users.noreply.github.com> Date: Tue May 16 23:46:40 2023 +1000 fix: remove skip preflight from cli (coral-xyz#2492) --------- Co-authored-by: acheron <acheroncrypto@gmail.com> commit 89e94d1 Author: Ryan De La O <rdelao@users.noreply.github.com> Date: Sat May 13 02:17:47 2023 -0700 cli: Fix incorrect metadata.address generation (coral-xyz#2485) Currently when running 'anchor deploy --program-name <name> --program-keypair <specified keypair>' the cli still uses the auto-generated keypair when fetching the program id to add to the IDL metadata at the end. It should instead use the address from the specified keypair. --------- Co-authored-by: acheron <acheroncrypto@gmail.com> commit 714d524 Author: CanardMandarin <thibault.marboud@gmail.com> Date: Tue May 9 16:17:11 2023 +0200 lang: Add error message when Mint and TokenAccount with `init` are not ordered correctly (coral-xyz#2484) commit 9a93a2e Author: James <juicy66173@gmail.com> Date: Mon May 8 10:17:51 2023 +0100 ts: Improve IDL typing (coral-xyz#2482) * Use XOR pattern for enum variants to prevent two variants being used at the same time. * Fix unknown for types like Option<[u8; 32]> commit d1ddf00 Author: CanardMandarin <thibault.marboud@gmail.com> Date: Sun May 7 11:03:37 2023 +0200 lang: Fix incorrectly checking the first init constraint (coral-xyz#2483)

Co-authored-by: acheron <acheroncrypto@gmail.com>

Add example using the instructions array for a state RPC coral-xyz#84

ea912b8

acheroncrypto reviewed May 22, 2023

View reviewed changes

acheroncrypto added the examples label May 22, 2023

Aursen reviewed May 22, 2023

View reviewed changes

examples/tutorial/basic-5/programs/basic-5/src/lib.rs Outdated Show resolved Hide resolved

lastemp added 2 commits May 22, 2023 17:20

Add example using the instructions array for a state RPC coral-xyz#84

6638deb

Add example using the instructions array for a state RPC coral-xyz#84

7e2f1f6

acheroncrypto reviewed May 22, 2023

View reviewed changes

Add example using the instructions array for a state RPC coral-xyz#84

00695c2

acheroncrypto reviewed May 23, 2023

View reviewed changes

examples/tutorial/basic-5/Anchor.toml Outdated Show resolved Hide resolved

examples/tutorial/basic-5/programs/basic-5/src/lib.rs Outdated Show resolved Hide resolved

examples/tutorial/basic-5/tests/basic-5.ts Outdated Show resolved Hide resolved

Add example using the instructions array for a state RPC coral-xyz#84

d548863

lastemp added 2 commits May 24, 2023 12:39

Add example using the instructions array for a state RPC coral-xyz#84

d1913d4

Add example using the instructions array for a state RPC coral-xyz#84

82309fd

acheroncrypto added 4 commits May 24, 2023 13:03

Update lockfile

f6134bc

Await the result and log the error reason

51e0835

Remove chai types(error)

f67b051

Use the local wallet instead of creating a new one each time

9b5dbc9

acheroncrypto approved these changes May 24, 2023

View reviewed changes

acheroncrypto merged commit c3625c8 into coral-xyz:master May 24, 2023

vadorovsky pushed a commit to Lightprotocol/anchor that referenced this pull request Jun 20, 2023

examples: Add an example with instruction method (coral-xyz#2501)

5334ad9

Co-authored-by: acheron <acheroncrypto@gmail.com>

ananas-block pushed a commit to Lightprotocol/anchor that referenced this pull request Jun 20, 2023

examples: Add an example with instruction method (coral-xyz#2501)

9f292f8

Co-authored-by: acheron <acheroncrypto@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add example using the instructions array for a state RPC #84 #2501

Add example using the instructions array for a state RPC #84 #2501

lastemp commented May 22, 2023 •

edited

Loading

vercel bot commented May 22, 2023

acheroncrypto left a comment

lastemp commented May 22, 2023

acheroncrypto left a comment

acheroncrypto commented May 23, 2023

lastemp commented May 23, 2023

acheroncrypto commented May 23, 2023

lastemp commented May 24, 2023

acheroncrypto left a comment

lastemp commented May 24, 2023

Add example using the instructions array for a state RPC #84 #2501

Add example using the instructions array for a state RPC #84 #2501

Conversation

lastemp commented May 22, 2023 • edited Loading

vercel bot commented May 22, 2023

acheroncrypto left a comment

Choose a reason for hiding this comment

lastemp commented May 22, 2023

acheroncrypto left a comment

Choose a reason for hiding this comment

acheroncrypto commented May 23, 2023

lastemp commented May 23, 2023

acheroncrypto commented May 23, 2023

lastemp commented May 24, 2023

acheroncrypto left a comment

Choose a reason for hiding this comment

lastemp commented May 24, 2023

lastemp commented May 22, 2023 •

edited

Loading