Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdlib: check for metadata key before rojig #3948

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 18, 2024

We've been abusing the rojig key for a long time now to carry artifact name and summary information. Since then, a more appropriate `metadata key is now supported in the treefile for our purposes.

Check the metadata key first, but fallback to the rojig key to give time for src config repos to migrate.

We've been abusing the `rojig` key for a long time now to carry artifact
name and summary information. Since then, a more appropriate `metadata
key is now supported in the treefile for our purposes.

Check the `metadata` key first, but fallback to the `rojig` key to give
time for src config repos to migrate.
@jlebon
Copy link
Member Author

jlebon commented Nov 18, 2024

Requires: coreos/rpm-ostree#5165

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2024

New enough rpm-ostree now in continuous tag!

@jlebon jlebon merged commit 8b32fc8 into coreos:main Nov 20, 2024
5 checks passed
@jlebon jlebon deleted the pr/derojig branch November 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants