Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: manifests: move from rojig to metadata #1651

Merged
merged 1 commit into from
Nov 26, 2024
Merged

NO-JIRA: manifests: move from rojig to metadata #1651

merged 1 commit into from
Nov 26, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 19, 2024

Now that cosa supports looking at the metadata key, let's finally stop abusing the rojig key.

@jlebon
manifests: move from rojig to metadata
7f698a8 
Now that cosa supports looking at the `metadata` key, let's finally stop
abusing the `rojig` key.
@jlebon
Copy link
Member Author

jlebon commented Nov 19, 2024

Requires: coreos/coreos-assembler#3948

@openshift-ci openshift-ci bot requested review from c4rt0 and jbtrystram November 19, 2024 20:11
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2024
@jlebon
Copy link
Member Author

jlebon commented Nov 19, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2024

/retest

1 similar comment
@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2024

/retest

dustymabe
dustymabe approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Nov 20, 2024

It's still using an older cosa.
/retest

@jlebon jlebon mentioned this pull request Nov 22, 2024
Merged
@jlebon
Copy link
Member Author

jlebon commented Nov 25, 2024

We've branched now.
/hold cancel

@jlebon jlebon changed the title manifests: move from rojig to metadata NO-JIRA: manifests: move from rojig to metadata Nov 25, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

Now that cosa supports looking at the metadata key, let's finally stop abusing the rojig key.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 492753c and 2 for PR HEAD 7f698a8 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 492753c and 2 for PR HEAD 7f698a8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 492753c and 2 for PR HEAD 7f698a8 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3ea9151 into openshift:master Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@c4rt0 c4rt0 Awaiting requested review from c4rt0

@jbtrystram jbtrystram Awaiting requested review from jbtrystram

Assignees

@dustymabe dustymabe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlebon @openshift-ci-robot @dustymabe