Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ContractCodeHistoryEntry populate 'updated' and 'msg' fields from proto data #451

Merged

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Dec 3, 2023

a simple bugfix to ContractCodeHistoryEntry type. Rather then using default values of None and vec![] for updated and msg respectively, parse those fields out of the protobuf response instead

@tony-iqlusion tony-iqlusion merged commit d38e52e into cosmos:main Feb 1, 2024
7 checks passed
@tony-iqlusion tony-iqlusion mentioned this pull request Mar 15, 2024
kent-3 added a commit to kent-3/cosmos-rust that referenced this pull request Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454)

* cosmos-sdk-proto: add more IBC related names (cosmos#457)

* cosmrs: added support for validator-related queries in staking module (cosmos#453)

* correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451)

* cosmos-sdk-proto: update tonic to 0.11 (cosmos#460)

Minimise lockfile changes

* Bump tendermint-rs dependencies to v0.35 (cosmos#461)

* cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462)

Uses the recently added support in `prost-build` for automatically
generating impls of the `Name` trait for IBC-related types, rather than
maintaining them by hand in the `type_names` module.

Unfortunately we can only do this for the IBC protos, since we build the
others using `buf`.

* cosmos-sdk-proto v0.21.0 (cosmos#463)

* cosmrs v0.16.0 (cosmos#464)

* cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465)

* cosmos-sdk-proto v0.21.1 (cosmos#466)

---------

Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Co-authored-by: Fabien Penso <git@pen.so>
Co-authored-by: Alex Butler <alexheretic@gmail.com>
Co-authored-by: Tony Arcieri (iqlusion) <tony@iqlusion.io>
kent-3 added a commit to kent-3/cosmos-rust that referenced this pull request Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454)

* cosmos-sdk-proto: add more IBC related names (cosmos#457)

* cosmrs: added support for validator-related queries in staking module (cosmos#453)

* correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451)

* cosmos-sdk-proto: update tonic to 0.11 (cosmos#460)

Minimise lockfile changes

* Bump tendermint-rs dependencies to v0.35 (cosmos#461)

* cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462)

Uses the recently added support in `prost-build` for automatically
generating impls of the `Name` trait for IBC-related types, rather than
maintaining them by hand in the `type_names` module.

Unfortunately we can only do this for the IBC protos, since we build the
others using `buf`.

* cosmos-sdk-proto v0.21.0 (cosmos#463)

* cosmrs v0.16.0 (cosmos#464)

* cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465)

* cosmos-sdk-proto v0.21.1 (cosmos#466)

---------

Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Co-authored-by: Fabien Penso <git@pen.so>
Co-authored-by: Alex Butler <alexheretic@gmail.com>
Co-authored-by: Tony Arcieri (iqlusion) <tony@iqlusion.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants