Add more IBC related names #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really we should switch to generating this automatically, now that it's possible |
tony-iqlusion
approved these changes
Jan 16, 2024
Very much agree with this, as well as having serde added. |
Can you (re)give me pointers to adding this automatically? I might look at it at some point if no one has done it. |
|
@penso in https://docs.rs/prost-build/latest/prost_build/struct.Config.html The newly added https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.enable_type_names |
kent-3
added a commit
to kent-3/cosmos-rust
that referenced
this pull request
Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454) * cosmos-sdk-proto: add more IBC related names (cosmos#457) * cosmrs: added support for validator-related queries in staking module (cosmos#453) * correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451) * cosmos-sdk-proto: update tonic to 0.11 (cosmos#460) Minimise lockfile changes * Bump tendermint-rs dependencies to v0.35 (cosmos#461) * cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462) Uses the recently added support in `prost-build` for automatically generating impls of the `Name` trait for IBC-related types, rather than maintaining them by hand in the `type_names` module. Unfortunately we can only do this for the IBC protos, since we build the others using `buf`. * cosmos-sdk-proto v0.21.0 (cosmos#463) * cosmrs v0.16.0 (cosmos#464) * cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465) * cosmos-sdk-proto v0.21.1 (cosmos#466) --------- Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com> Co-authored-by: Fabien Penso <git@pen.so> Co-authored-by: Alex Butler <alexheretic@gmail.com> Co-authored-by: Tony Arcieri (iqlusion) <tony@iqlusion.io>
kent-3
added a commit
to kent-3/cosmos-rust
that referenced
this pull request
Apr 15, 2024
* cosmrs: expose `base::query` module and pagination types (cosmos#454) * cosmos-sdk-proto: add more IBC related names (cosmos#457) * cosmrs: added support for validator-related queries in staking module (cosmos#453) * correctly populate 'updated' and 'msg' fields from proto responses (cosmos#451) * cosmos-sdk-proto: update tonic to 0.11 (cosmos#460) Minimise lockfile changes * Bump tendermint-rs dependencies to v0.35 (cosmos#461) * cosmos-sdk-proto: use `prost-build` to gen IBC `Name` impls (cosmos#462) Uses the recently added support in `prost-build` for automatically generating impls of the `Name` trait for IBC-related types, rather than maintaining them by hand in the `type_names` module. Unfortunately we can only do this for the IBC protos, since we build the others using `buf`. * cosmos-sdk-proto v0.21.0 (cosmos#463) * cosmrs v0.16.0 (cosmos#464) * cosmos-sdk-proto: remove deprecated `MessageExt` methods (cosmos#465) * cosmos-sdk-proto v0.21.1 (cosmos#466) --------- Co-authored-by: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com> Co-authored-by: Fabien Penso <git@pen.so> Co-authored-by: Alex Butler <alexheretic@gmail.com> Co-authored-by: Tony Arcieri (iqlusion) <tony@iqlusion.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few missing type names implementations.