Remove IBC protos in favour of the ibc-proto
crate
#459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #458
Closes: #442
Closes: #83
As promised, here is my follow-up to #458 and its corresponding issue in the ibc-proto-rs repository.
Here is the corresponding PR in
ibc-proto
which removes the generated Cosmos SDK protos and uses them viacosmos-sdk-proto
instead: cosmos/ibc-proto-rs#187Changes
ics23
crate instead of bundling them incosmos-sdk-proto
pbjson
.TODO
ics23
v0.11.1 once released (needed forinformalsystems-pbjson
v0.7.0)informalsystems-pbjson
to v0.7.0 ics23#274tendermint-proto
v0.34.1 once released (needed for missing serde annotations on some protos)Questions
serde
to match the corresponding feature inibc-proto
, but perhapspbjson
orprotojson
is a better name?This PR is probably best reviewed commit by commit.
@tony-iqlusion This is by no mean the definitive way to go about deduplicating the work, so I am eager to hear what you think about this and to discuss further with you how best to proceeded.