Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBC protos in favour of the ibc-proto crate #459

Closed
wants to merge 8 commits into from

Conversation

romac
Copy link
Member

@romac romac commented Jan 30, 2024

Closes: #458
Closes: #442
Closes: #83

As promised, here is my follow-up to #458 and its corresponding issue in the ibc-proto-rs repository.

Here is the corresponding PR in ibc-proto which removes the generated Cosmos SDK protos and uses them via cosmos-sdk-proto instead: cosmos/ibc-proto-rs#187

Changes

  • Remove ibc-go submodule and the corresponding generated proto definitions
  • Update Cosmos SDK protos to v0.47.0
  • Re-export ICS 23 proto definitions from the ics23 crate instead of bundling them in cosmos-sdk-proto
  • Add no-std compatible ProtoJSON (de)serialization to all Protobuf definitions, via Informal's fork of pbjson.

TODO

Questions

  • Do we want to update the Cosmos SDK protos further, eg. to v0.50.x?
  • What's the best name for the feature guarding the ProtoJSON serialization code? Right now it's serde to match the corresponding feature in ibc-proto, but perhaps pbjson or protojson is a better name?

This PR is probably best reviewed commit by commit.

@tony-iqlusion This is by no mean the definitive way to go about deduplicating the work, so I am eager to hear what you think about this and to discuss further with you how best to proceeded.

@tony-iqlusion
Copy link
Member

@romac seems like you're unblocked on this if you'd like to try to move it forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abandon cosmos-sdk-proto in favor of ibc-proto? Update ibc-go types adding support for json
2 participants