-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proto: Add missing serde derives on Protobuf definitions #1389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, we'll need this in cometbft-rs too!
Before we can use the buf plugin to generate the majority of serde impls, that is.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
- Coverage 60.1% 59.3% -0.8%
=======================================
Files 271 271
Lines 26221 26549 +328
=======================================
- Hits 15768 15761 -7
- Misses 10453 10788 +335 ☔ View full report in Codecov by Sentry. |
.changelog/