Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: Add missing serde derives on Protobuf definitions #1389

Merged
merged 7 commits into from
Apr 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Jan 30, 2024

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, we'll need this in cometbft-rs too!
Before we can use the buf plugin to generate the majority of serde impls, that is.

proto/Cargo.toml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 23.68421% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 59.3%. Comparing base (99ed0b9) to head (acc17cc).
Report is 1 commits behind head on main.

❗ Current head acc17cc differs from pull request most recent head 8d01b40. Consider uploading reports for the commit 8d01b40 to get more accurate results

Files Patch % Lines
tendermint/src/private_key.rs 0.0% 10 Missing ⚠️
tendermint/src/crypto/ed25519/signing_key.rs 0.0% 6 Missing ⚠️
tools/proto-compiler/src/constants.rs 0.0% 6 Missing ⚠️
tendermint/src/public_key.rs 42.8% 4 Missing ⚠️
tendermint/src/crypto/ed25519/verification_key.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1389     +/-   ##
=======================================
- Coverage   60.1%   59.3%   -0.8%     
=======================================
  Files        271     271             
  Lines      26221   26549    +328     
=======================================
- Hits       15768   15761      -7     
- Misses     10453   10788    +335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac marked this pull request as ready for review March 19, 2024 12:43
@romac romac changed the title Add missing serde derives on some Protobuf definitions proto: Add missing serde derives on some Protobuf definitions Mar 19, 2024
@romac romac changed the title proto: Add missing serde derives on some Protobuf definitions proto: Add missing serde derives o Protobuf definitions Mar 19, 2024
@romac romac changed the title proto: Add missing serde derives o Protobuf definitions proto: Add missing serde derives on Protobuf definitions Mar 19, 2024
@romac romac merged commit c90bf9c into main Apr 5, 2024
23 checks passed
@romac romac deleted the romac/missing-serde-proto branch April 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants