fix: nil pointer when quitting simd start (#13743)

* fix: nil pointer when quitting `simd start` * log error
cosmos · Nov 3, 2022 · 27f9851 · 27f9851
1 parent ad0e41d
commit 27f9851
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 34 deletions.
diff --git a/scripts/mockgen.sh b/scripts/mockgen.sh
@@ -5,7 +5,6 @@ $mockgen_cmd -source=client/account_retriever.go -package mock -destination test
 $mockgen_cmd -package mock -destination testutil/mock/tendermint_tm_db_DB.go github.com/tendermint/tm-db DB
 $mockgen_cmd -source=types/module/module.go -package mock -destination testutil/mock/types_module_module.go
 $mockgen_cmd -source=types/invariant.go -package mock -destination testutil/mock/types_invariant.go
-$mockgen_cmd -source=types/router.go -package mock -destination testutil/mock/types_router.go
 $mockgen_cmd -package mock -destination testutil/mock/grpc_server.go github.com/cosmos/gogoproto/grpc Server
 $mockgen_cmd -package mock -destination testutil/mock/tendermint_tendermint_libs_log_DB.go github.com/tendermint/tendermint/libs/log Logger
 $mockgen_cmd -source=orm/model/ormtable/hooks.go -package ormmocks -destination orm/testing/ormmocks/hooks.go

diff --git a/server/start.go b/server/start.go
@@ -289,7 +289,13 @@ func startInProcess(ctx *Context, clientCtx client.Context, appCreator types.App
 		if fn != nil {
 			fn()
 		}
-		traceWriter.Close()
+
+		// if flagTraceStore is not used then traceWriter is nil
+		if traceWriter != nil {
+			if err = traceWriter.Close(); err != nil {
+				ctx.Logger.Error("failed to close trace writer", "err", err)
+			}
+		}
 	}
 
 	config, err := serverconfig.GetConfig(ctx.Viper)

diff --git a/testutil/mock/types_router.go b/testutil/mock/types_router.go