Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer when quitting simd start #13743

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Discovered while doing #13742:

  • Exiting simd start gives a nil pointer
  • Remove unused mock

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner November 3, 2022 10:19
@julienrbrt julienrbrt changed the title refactor: nil pointer when quitting simd start fix: nil pointer when quitting simd start Nov 3, 2022
server/start.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #13743 (88b6bbf) into main (ad0e41d) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13743      +/-   ##
==========================================
- Coverage   55.53%   55.43%   -0.10%     
==========================================
  Files         656      646      -10     
  Lines       56190    55779     -411     
==========================================
- Hits        31207    30923     -284     
+ Misses      22431    22340      -91     
+ Partials     2552     2516      -36     
Impacted Files Coverage Δ
tx/textual/valuerenderer/string.go
tx/textual/valuerenderer/coins.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/duration.go
tx/textual/valuerenderer/message.go
tx/textual/valuerenderer/timestamp.go
x/staking/simulation/operations.go 75.91% <0.00%> (+1.37%) ⬆️

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Nit: Could we fix the error check before merge

@julienrbrt julienrbrt enabled auto-merge (squash) November 3, 2022 11:12
@julienrbrt julienrbrt merged commit 27f9851 into main Nov 3, 2022
@julienrbrt julienrbrt deleted the julien/small-fixes branch November 3, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants