You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
./build/simd is a master node built with above commit hash
./build/v042_node is a v0.42.9 node
Add a key on v042
➜ cosmos-sdk git:(master) ./build/v042_node keys add jack --keyring-backend test
- name: jack
type: local
address: cosmos15zz5edm79ga3jr6qd2sq5jsthcgutde5emtnhh
pubkey: cosmospub1addwnpepq2j7xj9esq378vx8yjgrc3k93kkdaetlsn94kjkyj6xzmkf8aggaxpz4as2
# snip
Make sure the key shows up
➜ cosmos-sdk git:(master) ./build/v042_node keys show jack --keyring-backend test
- name: jack
type: local
address: cosmos15zz5edm79ga3jr6qd2sq5jsthcgutde5emtnhh
pubkey: cosmospub1addwnpepq2j7xj9esq378vx8yjgrc3k93kkdaetlsn94kjkyj6xzmkf8aggaxpz4as2
# snip
Run the same command with the master keyring
➜ cosmos-sdk git:(master) ./build/simd keys show jack --keyring-backend test
Error: jack is not a valid name or address: decoding bech32 failed: invalid bech32 string length 4
Usage:
simd keys show [name_or_address [name_or_address...]] [flags]
Notes:
./build/simd keys show jack.info --keyring-backend test works and shows the correct key. I think we might have forgotten to migrate the name itself
./build/simd keys list --keyring-backend test also works and shows jack's key.
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged
Contributor assigned/self-assigned
The text was updated successfully, but these errors were encountered:
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->
## Description
Closes: #10219
Migrate key names correctly when migrating from v0.42.9 to master keyring
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Summary of Bug
After keyring migration, we can't
keys show
by name anymoreVersion
6e70d25, though it's probably after #9695
Steps to Reproduce
./build/simd
is a master node built with above commit hash./build/v042_node
is a v0.42.9 nodeAdd a key on v042
Make sure the key shows up
Run the same command with the master keyring
➜ cosmos-sdk git:(master) ./build/simd keys show jack --keyring-backend test Error: jack is not a valid name or address: decoding bech32 failed: invalid bech32 string length 4 Usage: simd keys show [name_or_address [name_or_address...]] [flags]
Notes:
./build/simd keys show jack.info --keyring-backend test
works and shows the correct key. I think we might have forgotten to migrate the name itself./build/simd keys list --keyring-backend test
also works and shows jack's key.For Admin Use
The text was updated successfully, but these errors were encountered: