-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Migrate key names correctly #10328
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10328 +/- ##
=======================================
Coverage 64.19% 64.19%
=======================================
Files 575 575
Lines 54919 54923 +4
=======================================
+ Hits 35254 35257 +3
- Misses 17662 17663 +1
Partials 2003 2003
|
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to not expose InfoKey
everywhere, just inside the relevant functions in crypto/keyring
package
…khita/fix-keyring-migration
…khita/fix-keyring-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
…khita/fix-keyring-migration
…khita/fix-keyring-migration
…khita/fix-keyring-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. I tested the repro described in the original issue. Thanks @likhita-809!
Some small nits.
…khita/fix-keyring-migration
Description
Closes: #10219
Migrate key names correctly when migrating from v0.42.9 to master keyring
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change