Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on using tipped transactions #10426

Closed
1 of 6 tasks
Tracked by #11096
amaury1093 opened this issue Oct 22, 2021 · 0 comments · Fixed by #11426 or #11858
Closed
1 of 6 tasks
Tracked by #11096

Docs on using tipped transactions #10426

amaury1093 opened this issue Oct 22, 2021 · 0 comments · Fixed by #11426 or #11858
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Oct 22, 2021

Part of the TX working group.

Summary

Add docs on what tipped transactions are, and how to use them.

Problem Definition

In #10208 we added a Tips middleware. There are currently no docs.

Proposal

This docs change be thought as 2 pieces, which can be done in 2 PRs.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added the T:Docs Changes and features related to documentation. label Oct 22, 2021
@amaury1093 amaury1093 mentioned this issue Mar 9, 2022
56 tasks
@amaury1093 amaury1093 added this to the v0.46 milestone Mar 10, 2022
@amaury1093 amaury1093 moved this from Icebox to Ready in Cosmos SDK Maintenance Mar 10, 2022
@amaury1093 amaury1093 self-assigned this Mar 14, 2022
@amaury1093 amaury1093 moved this from Ready to In Progress in Cosmos SDK Maintenance Mar 15, 2022
@amaury1093 amaury1093 moved this from In Progress to In Review in Cosmos SDK Maintenance Apr 1, 2022
@mergify mergify bot closed this as completed in #11426 Apr 4, 2022
Repository owner moved this from In Review to Done in Cosmos SDK Maintenance Apr 4, 2022
mergify bot pushed a commit that referenced this issue Apr 4, 2022
## Description

Closes: #10426 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@amaury1093 amaury1093 reopened this Apr 4, 2022
@amaury1093 amaury1093 moved this from Done to Ready in Cosmos SDK Maintenance Apr 4, 2022
Repository owner moved this from Ready to Done in Cosmos SDK Maintenance May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
No open projects
Archived in project
1 participant