feat: Add fee.{payer,granter} and tip fields to StdSignDoc

[amaury1093]

Description

Closes: #10346

StdSignDoc used by LEGACY_AMINO_JSON:

{
  "account_number": {number},
  "chain_id": {string},
  "fee": {
    "amount": [{"amount": {number}, "denom": {string}}, ...],
    "gas": {number},
+   "payer": {string}, // optional, omitempty, chain-specific bech32 address
+   "granter": {string}, // optional, omitempty, chain-specific bech32 address
  },
  "memo": {string},
  "msgs": [{arbitrary}],
  "sequence": {number},
+  "tip": { // optional, whole struct is omitempty
+    "tipper": "cosmos1...", // cannot be ""
+    "amount": [{"amount": {number}, "denom": {string}}, ...], // array of coins, can be [], but not omitempty
+  }
}

Depends on:

• revert: Remove SIGN_MODE_AMINO_AUX #10322

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[amaury1093]

Putting this PR as R4R

[codecov]

Codecov Report

Merging #10348 (6b9abab) into master (994219a) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master   #10348      +/-   ##
==========================================
- Coverage   64.42%   64.41%   -0.02%     
==========================================
  Files         573      573              
  Lines       54619    54649      +30     
==========================================
+ Hits        35190    35202      +12     
- Misses      17432    17449      +17     
- Partials     1997     1998       +1     

Impacted Files	Coverage Δ
x/auth/migrations/legacytx/stdsignmsg.go	0.00% <0.00%> (ø)
x/auth/migrations/legacytx/stdtx.go	82.14% <ø> (ø)
x/auth/migrations/legacytx/stdsign.go	77.52% <71.42%> (-0.79%)	⬇️
x/auth/tx/legacy_amino_json.go	87.23% <87.50%> (-0.77%)	⬇️
x/auth/migrations/legacytx/amino_signing.go	63.82% <100.00%> (ø)
x/auth/tx/builder.go	78.60% <100.00%> (+2.54%)	⬆️
x/auth/tx/direct_aux.go	88.88% <100.00%> (ø)
x/distribution/simulation/operations.go	80.54% <0.00%> (-9.73%)	⬇️

[atheeshp]

lgtm

[i-norden]

Hi Amaury, looking through this I can't find much to change. I think one of the unit tests is redundant but otherwise looks great.

At this stage do the docs/core/transactions.md, docs/basics/tx-lifecycle.md, docs/basics/gas-fees.md need to be updated?

[amaury1093]

Thanks a lot @i-norden !

At this stage do the docs/core/transactions.md, docs/basics/tx-lifecycle.md, docs/basics/gas-fees.md need to be updated?

I created an issue for docs: #10426. I'd like the docs about this PR's changes to fit in nicely in the larger transactions tips story.