Block height on proofs is wrong after restart abci app

[ethanfrey]

This is tested on the master branches (basecoin v0.5.2, tendermint v0.10.0)

Shell 1:

rm -rf ~/.basecoin
basecoin init
basecoin start --without-tendermint

Shell 2:

rm -rf ~/.tendermint
tendermint init
tendermint node

Shell 3:

sleep 300
curl http://localhost:46657/status 2>/dev/null | jq .result.latest_block_height
# 276
curl http://localhost:46657/abci_query\?data\=0x1B1BE55F969F54064628A63B9559E7C21C925165 2>/dev/null | jq .result.response.height
# 278

In this case they should be similar, maybe 1 or 2 blocks off due to the delay in the two commands... The first height comes from tendermint, the second from basecoin.

Trigger problem

Shell 1:

ctrl-c
basecoin start --without-tendermint

Shell 2:

ctrl-c
tendermint node

Shell 3:

curl http://localhost:46657/status 2>/dev/null | jq .result.latest_block_height
# 400
curl http://localhost:46657/abci_query\?data\=0x1B1BE55F969F54064628A63B9559E7C21C925165 2>/dev/null | jq .result.response.height
# 734

[ethanfrey]

@phomer this is the problem I was talking about, will try to reproduce with merkleeyes directly

[ethanfrey]

Added a cli test case in bugfix/106-wrong-height-on-restart that reproduces this problem cleanly.

Please add any fixes there and run make test_cli to verify they solved the problem.

Note: you can run DEBUG=1 make test_cli and it will dump out a lot more info to the console to help understand what all the return values are. If you need it.

[phomer]

The error I am seeing with make test_cli seems to be:

ASSERT:account must exist: ERROR: Response error: Height must be less than or equal to the current blockchain height

This appears to happen consistently with Query after a restart. Is this the expected error?

[ethanfrey]

Fixed with #129