WIP: #106 wrong height on restart #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice tests! I think the only issue here was that Basecoin hadn't implemented the handshake yet, so it was replaying blocks, even though merkleeyes was synced, which caused merkleeyes to get artificially "ahead" |
|
@ebuchman I'm gonna rebase this and merge it. Can you merge the merkleeyes branch? |
ethanfrey
force-pushed
the
bugfix/106-wrong-height-on-restart
branch
from
7361ba6
to
682f9ec
Compare
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
alexanderbez
added a commit
that referenced
this pull request
Apr 5, 2022
Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 5. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3.0.19...v5) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is an attempt to address the problem that all heights are off after the restart, and thus the light-client cannot make a decent proof.
There was a purported fix in
merkleeyes:fix-restart-height, this PR adds a cli test to demonstrate the problem, and updates the glide dependencies to the most recent version of that branch.When all tests pass and the merkleeyes branch is merged into develop, then this will be ready to merge.
To see the test issue, check out this branch, and try the following.
make allupdates all dependencies, compiles the binaries and runs all tests. Assuming this fails, run the second command to get more debug output on fixing the restart test. Notably the output of the basecoin server log.