Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(query/evidence): Evidence CLI query does not accept flags #13444

Closed
Pantani opened this issue Oct 4, 2022 · 0 comments · Fixed by #13740
Closed

bug(query/evidence): Evidence CLI query does not accept flags #13444

Pantani opened this issue Oct 4, 2022 · 0 comments · Fixed by #13740
Assignees
@likhita-809
Labels
C:CLI C:x/evidence T:Bug

Comments

@Pantani
Copy link

Pantani commented Oct 4, 2022

Summary of Bug

  • CLI query evidence command does not accept flags. The command tries to parse the flags as an argument:

Screen Shot 2022-10-04 at 01 15 33

Screen Shot 2022-10-04 at 01 15 38

  • Evidence API does not decode the hash properly. Query the evidence by hash from the CLI works but does not work by API:

Screen Shot 2022-10-04 at 01 17 27

Version

v0.46.1

Steps to Reproduce

  • Try to use flags to list all evidence
$ gaiad q evidence --output json
  • Try to use flags to fetch a specific evidence
$ gaiad q evidence 367BFE17837E11FE184FFF8F6E6CCE224DD97A8265C5EA5699806E8E7AF3AC91 --output json
  • Try to fetch the evidence by API
$ curl http://localhost:1317/cosmos/evidence/v1beta1/evidence/367BFE17837E11FE184FFF8F6E6CCE224DD97A8265C5EA5699806E8E7AF3AC91
  • Fetch the same evidence thought CLI should work
$ gaiad q evidence 367BFE17837E11FE184FFF8F6E6CCE224DD97A8265C5EA5699806E8E7AF3AC91
@Pantani Pantani mentioned this issue Oct 5, 2022
Merged
@atheeshp atheeshp self-assigned this Oct 6, 2022
@likhita-809 likhita-809 mentioned this issue Oct 6, 2022
Merged
19 tasks
@atheeshp atheeshp assigned likhita-809 and unassigned atheeshp Oct 6, 2022
@likhita-809 likhita-809 mentioned this issue Nov 3, 2022
Merged
19 tasks
@mergify mergify bot closed this as completed in #13740 Nov 4, 2022
mergify bot pushed a commit that referenced this issue Nov 4, 2022
@likhita-809
fix: Evidence API does not decode the hash properly (#13740)
2bb114a 
## Description

Closes: #13444 

This PR fixes the x/evidence api query which is not decoding the evidence hash properly because of its type ([]byte). We fix it with the following steps:
1. Adds a new proto field `hash` of type `string`
2. Make the old `evidence_hash` field deprecated
3. Updates query handler 

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@likhita-809 likhita-809

Labels
C:CLI C:x/evidence T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Evidence API does not decode the hash properly cosmos/cosmos-sdk
4 participants
@Pantani @alexanderbez @atheeshp @likhita-809