feat(e2e): add e2e tests for the evidence module #1779
Conversation
Pantani
requested review from
okwme,
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
cmwaters,
jackzampolin,
mmulji-ic and
glnro
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1779 +/- ##
=======================================
Coverage 43.13% 43.13%
=======================================
Files 15 15
Lines 1340 1340
=======================================
Hits 578 578
Misses 742 742
Partials 20 20 |
| @@ -0,0 +1,29 @@ | |||
| package e2e | |||
There was a problem hiding this comment.
A more complicated scenario would be to have blocks with the following:
- DuplicateVoteEvidence
- LightClientAttackEvidence
... and check for those as well. Future todo?
tests/e2e/e2e_exec_test.go
Outdated
| hash, | ||
| } | ||
|
|
||
| s.executeGaiaTxCommand(ctx, c, gaiaCommand, valIdx, func(stdOut []byte, stdErr []byte) bool { |
There was a problem hiding this comment.
Nit: we might want to rename or rework executeGaiaTxCommand for cli commands that don't require validation of the tx hash...keys and query subcommands would fall under this category.
There was a problem hiding this comment.
Yes, I agree! I also moved the other API queries to the querie.go file in this PR #1780. The evidence API seems not to be working well. I opened an issue in the cosmos-sdk repo (cosmos/cosmos-sdk#13444). We can only query by CLI now, my idea was to try to put all CLI exec commands in the same file, but we can move to e2e_query_test.go. WDYT?
# Conflicts: # tests/e2e/e2e_exec_test.go # tests/e2e/query.go
# Conflicts: # tests/e2e/chain.go # tests/e2e/e2e_setup_test.go # tests/e2e/query.go
close #1676
Description
Since the evidence module doesn't have gaiad tx, this PR only adds evidence into the genesis JSON and queries all evidence.