We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Height queries are now supported in the CLI client via #4382. A similar solution needs to be supported for the REST client.
Namely, each appropriate GET query endpoint will accept a height query param and this value is then passed onto the context.
height
Essentially the following logic will have to be added to each respective handler:
heightStr := r.FormValue("height") if heightStr != "" { height, err := strconv.Atoi(heightStr) if err != nil { // TODO: handler error } cliCtx = cliCtx.WithHeight(height) }
But maybe there is a cleaner way we can do this via middleware to reduce the amount of code we need to write.
The text was updated successfully, but these errors were encountered:
/cc @colin-axner :)
Sorry, something went wrong.
Negative height paramter's value leads to undefined behaviour
e6df636
Follow-up of #4505 Issue: #4501
alexanderbez
Successfully merging a pull request may close this issue.
Summary
Height queries are now supported in the CLI client via #4382. A similar solution needs to be supported for the REST client.
Namely, each appropriate GET query endpoint will accept a
height
query param and this value is then passed onto the context.Essentially the following logic will have to be added to each respective handler:
But maybe there is a cleaner way we can do this via middleware to reduce the amount of code we need to write.
For Admin Use
The text was updated successfully, but these errors were encountered: