Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: support height queries in rest client #4505

Merged
merged 6 commits into from
Jun 7, 2019
Merged

R4R: support height queries in rest client #4505

merged 6 commits into from
Jun 7, 2019

Conversation

colin-axner
Copy link
Contributor

Fixes #4501

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze approved these changes Jun 6, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change but otherwise LGTM

types/rest/rest.go Outdated Show resolved Hide resolved
types/rest/rest.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK. Thanks @colin-axner! This logic was added to all the relevant query endpoints, correct?

client/context/context.go Outdated Show resolved Hide resolved
types/rest/rest.go Show resolved Hide resolved
alessio
alessio reviewed Jun 6, 2019
View reviewed changes
types/rest/rest.go Outdated Show resolved Hide resolved
@colin-axner
Copy link
Contributor Author

TestedACK. Thanks @colin-axner! This logic was added to all the relevant query endpoints, correct?

All relevant endpoints should be covered now

@alexanderbez alexanderbez merged commit c777fb9 into cosmos:master Jun 7, 2019
alessio added a commit that referenced this pull request Jun 7, 2019
@alessio
Negative height paramter's value leads to undefined behaviour
e6df636 
Follow-up of #4505
Issue: #4501
@alessio alessio mentioned this pull request Jun 7, 2019
Merged
5 tasks
@jackzampolin
Copy link
Member

Can we make this a 0.34.8?

@alexanderbez
Copy link
Contributor

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez left review comments

@alessio alessio alessio left review comments

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Height Queries in REST Client
5 participants
@colin-axner @jackzampolin @alexanderbez @alessio @fedekunze