Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent community spend proposal from transferring funds to a ModuleAcc #4831

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [-t <tag>] [-m <msg>]

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #4831 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4831      +/-   ##
==========================================
- Coverage    54.2%   54.18%   -0.02%     
==========================================
  Files         269      269              
  Lines       17189    17191       +2     
==========================================
- Hits         9317     9315       -2     
- Misses       7182     7186       +4     
  Partials      690      690

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ☕️

@alexanderbez alexanderbez merged commit cbc802c into master Aug 2, 2019
@alexanderbez alexanderbez deleted the fedekunze/fix-comm-spend-proposal branch August 2, 2019 12:29
alexanderbez pushed a commit that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants