Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmovisor don't pass SIGTERM to subprocess #7740

Closed
1 of 4 tasks
yihuang opened this issue Oct 30, 2020 · 3 comments · Fixed by #7776
Closed
1 of 4 tasks

cosmovisor don't pass SIGTERM to subprocess #7740

yihuang opened this issue Oct 30, 2020 · 3 comments · Fixed by #7776

Comments

@yihuang
Copy link
Collaborator

yihuang commented Oct 30, 2020

Summary of Bug

When kill cosmovisor with SIGTERM, the chain process don't get killed.

Version

master

Steps to Reproduce

  • run cosmovisor
  • kill -TERM $pid-of-cosmovisor
  • ps aux|grep $chaind still exists

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio
Copy link
Contributor

alessio commented Nov 2, 2020

Hold on - why do you want to terminate cosmovisor's children upon their parent's death?

@yihuang
Copy link
Collaborator Author

yihuang commented Nov 2, 2020

Hold on - why do you want to terminate cosmovisor's children upon their parent's death?

When I run cosmovisor in process manager(supervisor), when I stop cosmovisor process, the chain process is left running at background.
I think cosmovisor is designed to be kind of a drop-in replacement of the chain process itself?

yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Nov 2, 2020
@alessio
Copy link
Contributor

alessio commented Nov 2, 2020

Yes, it is @yihuang. Makes sense to me

@mergify mergify bot closed this as completed in #7776 Nov 13, 2020
mergify bot added a commit that referenced this issue Nov 13, 2020
fix #7740

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants