-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmovisor: pass quit signals to subprocess #7776
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7776 +/- ##
=======================================
Coverage 54.17% 54.17%
=======================================
Files 612 612
Lines 38999 38999
=======================================
Hits 21129 21129
Misses 15697 15697
Partials 2173 2173 |
44e5e58
to
6c02b91
Compare
there seems to be race conditions detected by go test, I'm not sure why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@@ -39,6 +43,15 @@ func LaunchProcess(cfg *Config, args []string, stdout, stderr io.Writer) (bool, | |||
return false, fmt.Errorf("launching process %s %s: %w", bin, strings.Join(args, " "), err) | |||
} | |||
|
|||
sigs := make(chan os.Signal, 1) | |||
signal.Notify(sigs, syscall.SIGQUIT, syscall.SIGTERM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to handle SIGINT as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we need to document this behaviour too
Description
closes: #7740
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes