Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark state machine logic #984

Closed
adrianbrink opened this issue May 11, 2018 · 9 comments
Closed

Benchmark state machine logic #984

adrianbrink opened this issue May 11, 2018 · 9 comments
Labels
T: Performance Performance improvements

Comments

@adrianbrink
Copy link
Contributor

adrianbrink commented May 11, 2018

Having released new staking to a public testnet we noticed that it slows down the block production. We should have a framework that allows us to benchmark the per block actions. This will allow us to quickly identify performance issues and optimize reads/writes.

@rigelrozanski

@cwgoes
Copy link
Contributor

cwgoes commented May 12, 2018

One option: pipe statistics to Riemann, which has an official Go client, for easy visualization and debugging.

@cwgoes
Copy link
Contributor

cwgoes commented May 30, 2018

I think we can use the same benchmark for this and for gas (#1008).

@ebuchman ebuchman added T: Performance Performance improvements post-launch labels Jun 20, 2018
@jackzampolin jackzampolin changed the title Benchmark state machine logic to detect potential performance regressions Benchmark state machine logic Oct 12, 2018
@jackzampolin
Copy link
Member

jackzampolin commented Oct 12, 2018

My friends over at InfluxDB wrote this tool to debug their own datastore: https://github.com/influxdata/grade I would suggest this! But I think regardless this is an important piece of hardening.

@jackzampolin
Copy link
Member

Closing this issue, will track testing improvements elsewhere.

@rigelrozanski
Copy link
Contributor

Where?

@alexanderbez
Copy link
Contributor

We don't have any direct state-machine benchmarks. Our closest bet would be simulation.

@cwgoes cwgoes reopened this May 28, 2019
@cwgoes
Copy link
Contributor

cwgoes commented May 28, 2019

I think this is absolutely something the SDK should include. When we want to scale e.g. Gaia to high TPS we'll need to spend a lot of time optimizing transaction execution.

@elias-orijtech
Copy link
Contributor

Similar to or duplicate of #13981?

@tac0turtle
Copy link
Member

they seem different one is add telemetry and this one is to do bechmarks, want to work on this @elias-orijtech

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Performance Performance improvements
Projects
None yet
Development

No branches or pull requests

9 participants