Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make chain-id flag not strictly required for tx commands #10184

Merged
merged 6 commits into from
Sep 22, 2021

Conversation

technicallyty
Copy link
Contributor

Description

chain-id's can be specified in a client config to be used in CLI commands. This PR changes the ChainID flag to no longer be explicitly required, as this value can come from clientCtx via config.

Closes: #9644


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@technicallyty technicallyty changed the title fix: make chain-id flag not strictly required for commands fix: make chain-id flag not strictly required for tx commands Sep 16, 2021
@github-actions github-actions bot added the C:CLI label Sep 16, 2021
@orijbot
Copy link

orijbot commented Sep 17, 2021

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you add a changelog entry?

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending on changelog

@technicallyty technicallyty added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #10184 (72ad96b) into master (94377f1) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 72ad96b differs from pull request most recent head b784b28. Consider uploading reports for the commit b784b28 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10184   +/-   ##
=======================================
  Coverage   63.72%   63.73%           
=======================================
  Files         573      573           
  Lines       53766    53764    -2     
=======================================
+ Hits        34263    34264    +1     
+ Misses      17555    17552    -3     
  Partials     1948     1948           
Impacted Files Coverage Δ
client/flags/flags.go 21.81% <ø> (+0.76%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@mergify mergify bot merged commit 9ebd12b into master Sep 22, 2021
@mergify mergify bot deleted the ty/fix-chain_id branch September 22, 2021 08:38
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config isn't honored by init command
4 participants