Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve cli tx output #11818

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Closes: #7978


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Apr 28, 2022 that may be closed by this pull request
4 tasks
@github-actions github-actions bot added the C:CLI label Apr 28, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
client/context.go Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #11818 (6206c5a) into main (4f04bea) will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11818      +/-   ##
==========================================
- Coverage   65.99%   65.94%   -0.06%     
==========================================
  Files         671      669       -2     
  Lines       70788    70427     -361     
==========================================
- Hits        46720    46444     -276     
+ Misses      21373    21312      -61     
+ Partials     2695     2671      -24     
Impacted Files Coverage Δ
client/tx/tx.go 32.97% <0.00%> (-0.12%) ⬇️
client/context.go 66.12% <100.00%> (+0.37%) ⬆️
math/uint.go
math/int.go

@alexanderbez alexanderbez merged commit 0c0b4da into main Apr 28, 2022
@alexanderbez alexanderbez deleted the julien/7978-improve-cli-tx-output branch April 28, 2022 19:06
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve CLI tx output
3 participants