Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support custom r/w gRPC options #11889

Merged
merged 3 commits into from
May 6, 2022
Merged

feat!: support custom r/w gRPC options #11889

merged 3 commits into from
May 6, 2022

Conversation

alexanderbez
Copy link
Contributor

Description

Provide the ability for operators to set custom r/w gRPC options in app.toml. Note, operators are not required to update their app.toml as a safe guard is also added when values are 0 to use default values.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez added the C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. label May 6, 2022
@alexanderbez alexanderbez requested a review from a team as a code owner May 6, 2022 14:21
@alexanderbez alexanderbez changed the title feature: support custom r/w gRPC options feature!: support custom r/w gRPC options May 6, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez changed the title feature!: support custom r/w gRPC options feat!: support custom r/w gRPC options May 6, 2022
@aaronc
Copy link
Member

aaronc commented May 6, 2022

Can this be backported?

@alexanderbez
Copy link
Contributor Author

Can this be backported?

Yes! I think it should...as long as you don't mind the slight change to the StartGRPCServer API :p

@alexanderbez
Copy link
Contributor Author

Going to merge and we can decide to backport to what/if later.

@alexanderbez alexanderbez merged commit e3e65ac into main May 6, 2022
@alexanderbez alexanderbez deleted the bez/grpc-rw-opts branch May 6, 2022 15:04
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
72 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request May 25, 2023
zemyblue added a commit to Finschia/finschia-sdk that referenced this pull request May 27, 2023
* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request May 27, 2023
* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog

(cherry picked from commit 13ae1f6)
zemyblue added a commit to Finschia/finschia-sdk that referenced this pull request May 30, 2023
* feat: support custom r/w gRPC options (#1017)

* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889)

* chore: add simple unittest for app config

* chore: update changelog

(cherry picked from commit 13ae1f6)

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants