-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decouple x/nft
from simapp
#12233
Conversation
x/nft
from simapp
77c2e60
to
2f84c50
Compare
Hey, may I ask why? thanks :) |
Hey, yes, this is part of our process to migrate all the sdk modules to app-wiring: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like it's almost there! Great work @julienrbrt 👏
Codecov Report
@@ Coverage Diff @@
## main #12233 +/- ##
==========================================
- Coverage 66.14% 66.12% -0.03%
==========================================
Files 673 673
Lines 71163 71085 -78
==========================================
- Hits 47074 47007 -67
+ Misses 21445 21436 -9
+ Partials 2644 2642 -2
|
Description
Closes: #12038
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change