Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple x/nft from simapp #12233

Merged
merged 15 commits into from
Jun 14, 2022
Merged

feat: decouple x/nft from simapp #12233

merged 15 commits into from
Jun 14, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #12038


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title feat: decouple x/nftfrom simapp feat: decouple x/nft from simapp Jun 13, 2022
@github-actions github-actions bot added the C:CLI label Jun 13, 2022
@julienrbrt julienrbrt force-pushed the julien/nft-decouple-simapp branch from 77c2e60 to 2f84c50 Compare June 13, 2022 15:12
@julienrbrt julienrbrt marked this pull request as ready for review June 13, 2022 15:29
@julienrbrt julienrbrt requested a review from a team as a code owner June 13, 2022 15:29
@faddat
Copy link
Contributor

faddat commented Jun 13, 2022

Hey, may I ask why?

thanks :)

@julienrbrt
Copy link
Member Author

Hey, may I ask why?

thanks :)

Hey, yes, this is part of our process to migrate all the sdk modules to app-wiring:
#11899

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like it's almost there! Great work @julienrbrt 👏

CHANGELOG.md Outdated Show resolved Hide resolved
testutil/sims/app_helpers.go Outdated Show resolved Hide resolved
x/nft/simulation/decoder_test.go Outdated Show resolved Hide resolved
x/nft/simulation/genesis_test.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 13, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #12233 (1fee74c) into main (b786d5d) will decrease coverage by 0.02%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12233      +/-   ##
==========================================
- Coverage   66.14%   66.12%   -0.03%     
==========================================
  Files         673      673              
  Lines       71163    71085      -78     
==========================================
- Hits        47074    47007      -67     
+ Misses      21445    21436       -9     
+ Partials     2644     2642       -2     
Impacted Files Coverage Δ
testutil/network/network.go 56.79% <0.00%> (-1.94%) ⬇️
simapp/test_helpers.go 15.38% <22.22%> (-10.97%) ⬇️
x/nft/simulation/operations.go 71.42% <100.00%> (+3.06%) ⬆️
x/distribution/simulation/operations.go 80.43% <0.00%> (-9.79%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@julienrbrt julienrbrt merged commit df41b65 into main Jun 14, 2022
@julienrbrt julienrbrt deleted the julien/nft-decouple-simapp branch June 14, 2022 06:32
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/nft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/nft to use app wiring
4 participants