Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: operation simulation route in x/nft test #12278

Merged
merged 8 commits into from
Jun 16, 2022
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 16, 2022

Description

#12233 introduced a mistake in the NFT operation test.

  • This PR fixes it and ensure we check the operation errors in all tests, so mistakes like this cannot happen.
  • Removes the last bit of simapp from NFT and move helpers to testutil/sims

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review June 16, 2022 12:53
@julienrbrt julienrbrt requested a review from a team as a code owner June 16, 2022 12:53
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #12278 (0b2992b) into main (c68fa3b) will decrease coverage by 0.02%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12278      +/-   ##
==========================================
- Coverage   66.12%   66.10%   -0.03%     
==========================================
  Files         710      675      -35     
  Lines       74175    71280    -2895     
==========================================
- Hits        49048    47118    -1930     
+ Misses      22216    21518     -698     
+ Partials     2911     2644     -267     
Impacted Files Coverage Δ
simapp/test_helpers.go 15.38% <0.00%> (ø)
simapp/utils.go 21.62% <0.00%> (ø)
x/simulation/util.go 0.00% <0.00%> (ø)
x/nft/simulation/operations.go 68.36% <80.00%> (-3.07%) ⬇️
x/authz/simulation/operations.go 67.12% <100.00%> (ø)
x/bank/simulation/operations.go 81.84% <100.00%> (ø)
x/gov/simulation/operations.go 85.27% <100.00%> (ø)
x/group/simulation/operations.go 68.08% <100.00%> (ø)
x/slashing/simulation/operations.go 59.09% <100.00%> (ø)
... and 36 more

@julienrbrt julienrbrt merged commit 8fa2fab into main Jun 16, 2022
@julienrbrt julienrbrt deleted the julien/fix-sim-nft branch June 16, 2022 14:39
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants