refactor: helper method for register swagger api

[deepto98]

Description

Closes: #12149

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

I don't personally like the idea of Swagger existing in BaseApp. I'm sure we can move this somewhere else, perhaps the server package.

Also, let's be sure to get a changelog entry for this too.

[deepto98]

@alexanderbez I've moved the RegisterSwaggerAPI function to the server package, and added a changelog for the same.

[julienrbrt]

Do we still need this go import in app.go then?

// unnamed import of statik for swagger UI support
_ "github.com/cosmos/cosmos-sdk/client/docs/statik"` 

Nit: Maybe the file name should just be swagger.go.

[deepto98]

@julienrbrt I've removed the import and changed the filename to swagger.go.

[alexanderbez]

We don't need the _ "github.com/cosmos/cosmos-sdk/client/docs/statik" import?

[deepto98]

I think so, I removed it since you'd mentioned it here. Do you think its needed?

[alexanderbez]

I meant moving it back to another package. Have you tested this locally?

[alexanderbez]

bump @deepto98 :)

[julienrbrt]

Can you group the imports :)

[codecov]

Codecov Report

Merging #12352 (229a17a) into main (0b69859) will increase coverage by 0.03%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##             main   #12352      +/-   ##
==========================================
+ Coverage   65.16%   65.19%   +0.03%     
==========================================
  Files         692      693       +1     
  Lines       70837    70836       -1     
==========================================
+ Hits        46158    46179      +21     
+ Misses      22109    22086      -23     
- Partials     2570     2571       +1     

Impacted Files	Coverage Δ
server/swagger.go	0.00% <0.00%> (ø)
simapp/app.go	81.08% <100.00%> (+4.79%)	⬆️
x/group/keeper/keeper.go	58.66% <0.00%> (+0.39%)	⬆️
crypto/keys/internal/ecdsa/privkey.go	83.01% <0.00%> (+1.88%)	⬆️
x/distribution/simulation/operations.go	90.42% <0.00%> (+9.57%)	⬆️

[julienrbrt]

Hey @deepto98, this is almost ready to get merged 🙂. Can you implement the last two comments?

• Move the blank import to swagger.go (refactor: helper method for register swagger api #12352 (comment))
• remove the space (where my comment is) in the import and let your editor sort them. (refactor: helper method for register swagger api #12352 (comment))

[deepto98]

Okay, sure. Was a bit busy the past few days, will do these.

[julienrbrt]

Okay, sure. Was a bit busy the past few days, will do these.

No worries, thank you!! 👍🏾

[tac0turtle]

@julienrbrt want to take over this pr. we can close and reopen from a non fork

[tac0turtle]

@alexanderbez or @facundomedica could you push the pr across the finish line

[alexanderbez]

@alexanderbez or @facundomedica could you push the pr across the finish line

what is left? It seems @julienrbrt gave a thumps up so I think he's got it? If not, I can take a stab at it.

[julienrbrt]

Replaced by #12955