Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: helper method for register swagger api #12955

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 18, 2022

Description

Closes: #12149
Superseded #12352
Ran sh scripts/protoc-swagger-gen.sh


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #12955 (42f4fe3) into main (4fe7797) will decrease coverage by 0.33%.
The diff coverage is 55.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12955      +/-   ##
==========================================
- Coverage   55.87%   55.54%   -0.34%     
==========================================
  Files         646      647       +1     
  Lines       54895    54895              
==========================================
- Hits        30675    30491     -184     
- Misses      21762    21940     +178     
- Partials     2458     2464       +6     
Impacted Files Coverage Δ
server/swagger.go 0.00% <0.00%> (ø)
simapp/app.go 82.66% <0.00%> (+3.55%) ⬆️
x/distribution/keeper/params.go 75.00% <ø> (-3.58%) ⬇️
x/distribution/module.go 64.28% <ø> (ø)
store/cachekv/store.go 86.61% <45.45%> (+7.49%) ⬆️
types/dec_coin.go 98.41% <50.00%> (-0.79%) ⬇️
snapshots/manager.go 56.91% <57.14%> (+9.32%) ⬆️
crypto/keyring/keyring.go 61.95% <100.00%> (ø)
types/events.go 84.65% <100.00%> (+0.35%) ⬆️
x/distribution/abci.go 76.92% <100.00%> (-23.08%) ⬇️
... and 22 more

@julienrbrt julienrbrt merged commit 72b1a39 into main Aug 18, 2022
@julienrbrt julienrbrt deleted the julien/swagger branch August 18, 2022 10:19
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* refactor: helper method for register swagger api

* updates swagger.yaml

* `make update-swagger-docs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make re-usable helper method for RegisterSwaggerAPI
2 participants