-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: dockerfiles #14793
perf: dockerfiles #14793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Is it normal that the |
Example of failing rosetta test: https://github.com/cosmos/cosmos-sdk/actions/runs/4016196074/jobs/6898898930 |
exit 1;\ | ||
else \ | ||
echo "\033[92mSwagger docs are in sync\033[0m";\ | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanupd mix of spaces and tabs
I don't think so, but it is as well failing on main: https://github.com/cosmos/cosmos-sdk/actions/runs/4017094584/jobs/6900997441. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!!
(cherry picked from commit be9bd7a) # Conflicts: # CHANGELOG.md # Dockerfile # contrib/images/simd-env/Dockerfile
Description
Reworked Docker files to organize them and speedup build:
Before (time to build from the ./Dockerfile):
After:
Checked:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change