fix: correct path required proto testdata #14991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team and
likhita-809
and removed request for
a team
julienrbrt
changed the title
amaury1093
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
LGTM, proposed 2 alternatives, but this PR LGTM as-is too. Thanks @julienrbrt
| @@ -1,5 +1,5 @@ | |||
| // Code generated by protoc-gen-go-pulsar. DO NOT EDIT. | |||
| package testdata_pulsar | |||
| package testpb | |||
There was a problem hiding this comment.
An alternative we can do, is that instead of generating pulsar types in testutil/testdata_pulsar/testpb, we generate them in testutil/testdata/testpb. This way testdata_pulsar is not a directory with only one directory inside.
We would have:
testdata/*.go: gogotestdata/testpb/*.go: pulsar
Not sure if that's better or more confusing, but putting the idea out there.
There was a problem hiding this comment.
Yes, I was thinking of this, but thought it could be confusing. As you think the same too, this means it's not that confusing then 👍🏾 Doing that!
19 tasks
19 tasks
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
|
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2023
(cherry picked from commit a90569c) # Conflicts: # .golangci.yml # CHANGELOG.md # simapp/app.go # simapp/app_v2.go # testutil/assert_helpers.go # testutil/testdata/testpb/pulsar_query.go # testutil/testdata/testpb/query_grpc.pb.go # testutil/testdata/testpb/tx_grpc.pb.go # x/auth/ante/testutil_test.go
tac0turtle
pushed a commit
that referenced
this pull request
May 10, 2023
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
roy-dydx
pushed a commit
to dydxprotocol/cosmos-sdk
that referenced
this pull request
Jul 11, 2023
…smos#16083) Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha
pushed a commit
to InjectiveLabs/cosmos-sdk
that referenced
this pull request
Aug 15, 2023
…smos#16083) Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14988
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change