refactor!: deprecate sdk.Msg.GetSigners #15284
Conversation
github-actions
bot
added
C:CLI
C:x/auth
C:x/authz
C:x/genutil
…-deprecate-get-signers-2
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
removed
C:Cosmovisor
…-deprecate-get-signers-2
…-deprecate-get-signers-2
…-deprecate-get-signers-2
…-deprecate-get-signers-2
| @@ -943,7 +955,7 @@ func (app *BaseApp) runMsgs(ctx sdk.Context, msgs []sdk.Msg, mode execMode) (*sd | |||
| } | |||
|
|
|||
| // create message events | |||
| msgEvents := createEvents(msgResult.GetEvents(), msg) | |||
| msgEvents := createEvents(app.cdc, msgResult.GetEvents(), msg, msgsV2[i]) | |||
There was a problem hiding this comment.
Shouldn't we compare the two lengths of msgs and msgsV2 for preventing an out of bound?
There was a problem hiding this comment.
We can, but could we also document that part of the contract of the methods creating msgsV2 is that it has the same length as msgs?
|
|
||
| option go_package = "github.com/cosmos/cosmos-sdk/baseapp/testutil"; | ||
|
|
||
| message MsgCounter { | ||
| option (cosmos.msg.v1.signer) = "signer"; |
There was a problem hiding this comment.
We should add docs for that in the UPGRADING.md and somewhere in the docs website.
| @@ -133,6 +134,36 @@ var ( | |||
| _ servertypes.Application = (*SimApp)(nil) | |||
| ) | |||
|
|
|||
| // stdAccAddressCodec is a temporary address codec that we will use until we | |||
There was a problem hiding this comment.
does this have to be in app.go or can it be somewhere users can import to get the needed information?
There was a problem hiding this comment.
We can just refactor this to use address.Bech32Codec. Does how I've updated it in the latest commit look okay for now? It's still using the global but we can refactor that later.
|
Added #16294 around updating UPGRADING.md. Going to add this to the merge queue. I think it will be easier to address other issues in follow-ups given the massive size of this PR already. |
Description
Closes: #11275
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change