feat!: migrate group to sdk orm #15304
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
On it as we speak. |
julienrbrt
force-pushed
the
julien/group-orm
branch
from
ef57a06
to
6bd44b0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
x/group/orm.go
Outdated
| Admin: groupPolicyInfo.Admin, | ||
| Metadata: groupPolicyInfo.Metadata, | ||
| Version: groupPolicyInfo.Version, | ||
| DecisionPolicy: codectypes.AnyV2ToGogoAny(groupPolicyInfo.DecisionPolicy), |
There was a problem hiding this comment.
This does not set the CachedValue, so this is problematic.
github-actions
bot
added
C:Confix
| decisionPolicy := DecisionPolicy(nil) | ||
| err := cdc.UnpackAny(codectypes.AnyV2ToGogoAny(groupPolicyInfo.DecisionPolicy), &decisionPolicy) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("failed to transform decision policy: %s", err)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
|
||
| result.DecisionPolicy, err = codectypes.NewAnyWithValue(decisionPolicy) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("failed to transform decision policy: %s", err)) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Closes: #15295
Very much work in progress due to tests and migration. The rest should be ok.
The most important file is
state.proto.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change