Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orm): add sequence getter for auto increment tables #15320

Merged
merged 8 commits into from
Mar 9, 2023

Conversation

julienrbrt
Copy link
Member

Description

Needed by #15304


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner March 9, 2023 08:53
@julienrbrt julienrbrt changed the title feat: add current sequence getter for auto increment tables feat(orm): add current sequence getter for auto increment tables Mar 9, 2023
@github-actions github-actions bot added the C:orm label Mar 9, 2023
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be called Current or Last sequence? Maybe it should be LastInsertedSequence?

@julienrbrt
Copy link
Member Author

Should it be called Current or Last sequence? Maybe it should be LastInsertedSequence?

LastInsertedSequence does remove possible confusion yes, so I'll update to that 👍🏾

orm/model/ormtable/table.go Outdated Show resolved Hide resolved
julienrbrt and others added 3 commits March 9, 2023 15:33
Co-authored-by: Aaron Craelius <aaron@regen.network>
@julienrbrt julienrbrt changed the title feat(orm): add current sequence getter for auto increment tables feat(orm): add sequence getter for auto increment tables Mar 9, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) March 9, 2023 14:35
@julienrbrt julienrbrt merged commit ddd18ff into main Mar 9, 2023
@julienrbrt julienrbrt deleted the julien/orm-seq branch March 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants