Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add fallbacks for CoreAppModuleBasicAdaptor #16010

Merged
merged 4 commits into from
May 3, 2023

Conversation

julienrbrt
Copy link
Member

Description

ref: #15304, #15958 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner May 2, 2023 22:12
@julienrbrt julienrbrt requested a review from aaronc May 2, 2023 22:13
@github-actions github-actions bot added the C:orm label May 2, 2023
@github-actions

This comment has been minimized.

@@ -29,13 +29,17 @@ type ModuleDB interface {
// GenesisHandler returns an implementation of appmodule.HasGenesis
// to be embedded in or called from app module implementations.
// Ex:
// type Keeper struct {
// type AppModule struct {
Copy link
Member Author

@julienrbrt julienrbrt May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When not doing like this, I was getting a depinject issue in #15304 (37d2d62)

@julienrbrt
Copy link
Member Author

ORM tests are still failing but this is unrelated to this PR.

@julienrbrt julienrbrt enabled auto-merge May 3, 2023 16:38
@julienrbrt julienrbrt added this pull request to the merge queue May 3, 2023
Merged via the queue into main with commit b5c77d6 May 3, 2023
@julienrbrt julienrbrt deleted the julien/fix-core-module-adapter branch May 3, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants