refactor(auth): use collections for Account state management #16016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…query server interface
# Conflicts: # x/auth/keeper/grpc_query.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -22,7 +22,7 @@ | |||
| if err := cdc.UnmarshalInterface(iterator.Value(), &acc); err != nil { | |||
| return err | |||
| } | |||
| store.Set(types.AccountNumberStoreKey(acc.GetAccountNumber()), acc.GetAddress().Bytes()) | |||
| store.Set(accountNumberStoreKey(acc.GetAccountNumber()), acc.GetAddress().Bytes()) | |||
Check warning
Code scanning / gosec
Errors unhandled.
github-prbot
requested review from
a team,
aaronc and
alexanderbez
and removed request for
a team
tac0turtle
reviewed
May 15, 2023
|
seems like ci is still broken? |
# Conflicts: # x/auth/keeper/grpc_query.go # x/auth/keeper/keeper.go
tac0turtle
reviewed
May 26, 2023
| @@ -44,7 +44,7 @@ func TestSetPubKey(t *testing.T) { | |||
| // set accounts and create msg for each address | |||
| for i, addr := range addrs { | |||
| acc := suite.accountKeeper.NewAccountWithAddress(suite.ctx, addr) | |||
| require.NoError(t, acc.SetAccountNumber(uint64(i))) | |||
| require.NoError(t, acc.SetAccountNumber(uint64(i+1000))) | |||
There was a problem hiding this comment.
should we open an issue to redo these tests to avoid this overwriting?
There was a problem hiding this comment.
TBH, considering we're creating a new auth & accounts module I think we can leave things as is in x/auth assuming no more huge extra features will be put here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change