-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(auth): use collections for Account state management #16016
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
130df6d
unembed keeper from msg server, create query server to implement the …
6c8ea95
change collection name to just "Params"
fc2bbe4
Merge branch 'main' into tip/coll/auth_accounts_2
testinginprod 0b547dd
partially move accounts to use collections
8686088
fix sigverify test
e3ed273
fix sigverify test2
1f33e06
fix vesting tests
52de1f7
Merge branch 'main' into tip/coll/auth_accounts_3
a82c815
fix more tests
b351257
remove more unneeded things
2fe4672
more code to use collections
8704230
remove more unneeded things
fc4ad40
adjust gas tests
074c06d
Merge branch 'main' into tip/coll/auth_accounts_3
bf23c61
remove not relevant tests
c350695
Merge branch 'main' into tip/coll/auth_accounts_3
b8ed5e1
remove store decoder
6e11ac5
remove APIs that are not used anymore
49004af
chore lint
4d19a0c
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod 835c2e9
chore: lint
4225d10
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod a1796e5
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod 0a9ef82
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod cde0471
fix merge issues
82f566f
hack to make the test pass
e93e41f
chore: CHANGELOG.md
de0ea3a
remove: SetParams
6cc4cdb
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod d66986f
Merge branch 'main' into tip/coll/auth_accounts_3
3333da1
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod a18db18
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod b552c96
Merge branch 'main' into tip/coll/auth_accounts_3
testinginprod ddfaf08
fix merge
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we open an issue to redo these tests to avoid this overwriting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, considering we're creating a new auth & accounts module I think we can leave things as is in x/auth assuming no more huge extra features will be put here.