Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/group): v2 migration #16017

Merged
merged 3 commits into from
May 3, 2023
Merged

fix(x/group): v2 migration #16017

merged 3 commits into from
May 3, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod requested a review from a team as a code owner May 3, 2023 12:39
@github-prbot github-prbot requested review from a team, alexanderbez and samricotta and removed request for a team May 3, 2023 12:39
@github-actions

This comment has been minimized.

Sign in to view
@testinginprod testinginprod changed the title fix(x/groups): v2 migration fix(x/group): v2 migration May 3, 2023
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label May 3, 2023
julienrbrt
julienrbrt approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. good find!

@tac0turtle tac0turtle added this pull request to the merge queue May 3, 2023
Merged via the queue into main with commit 1d03f41 May 3, 2023
@tac0turtle tac0turtle deleted the tip/groups/fix_v2_migration branch May 3, 2023 13:14
mergify bot pushed a commit that referenced this pull request May 3, 2023
@testinginprod @mergify
fix(x/group): v2 migration (#16017)
6cb00b0 
Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit 1d03f41)

# Conflicts:
#	CHANGELOG.md
#	x/group/migrations/v2/migrate_test.go
@mergify mergify bot mentioned this pull request May 3, 2023
Merged
julienrbrt pushed a commit that referenced this pull request May 5, 2023
@mergify
fix(x/group): v2 migration (backport #16017) (#16018)
02e7275
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
@mergify @roy-dydx
fix(x/group): v2 migration (backport cosmos#16017) (cosmos#16018)
5e2ba47
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
@mergify @kakysha
fix(x/group): v2 migration (backport cosmos#16017) (cosmos#16018)
0b56f6d
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testinginprod @tac0turtle @julienrbrt