Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call AfterUnbondingInitiated for new unbonding entries only #16043

Merged
merged 3 commits into from
May 11, 2023

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented May 5, 2023

Description

Closes: #16042

An earlier change in #12967 introduced behaviour that causes the AfterUnbondingInitiated staking hook to be called with an invalid unbondingId in SetUnbondingDelegationEntry. The issue affects unbonding operations, redelegation behaviour does not seem to be affected. The issue can cause interchain-security provider chains to panic.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MSalopek MSalopek requested a review from a team as a code owner May 5, 2023 15:12
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team May 5, 2023 15:12
@julienrbrt
Copy link
Member

Can we get a changelog + a test here?

@MSalopek
Copy link
Contributor Author

MSalopek commented May 5, 2023

Can we get a changelog + a test here?

Yes. I'll add the tests and the changelog 👍

@faddat
Copy link
Contributor

faddat commented May 6, 2023

Currently working on:

Just curious if this will be able to be backported to 47, or if we need to begin to target main. Thanks.

@MSalopek MSalopek force-pushed the masa/fix-unbonding-hooks branch from f06b4bf to 9867dd7 Compare May 9, 2023 08:59
@MSalopek
Copy link
Contributor Author

MSalopek commented May 9, 2023

@julienrbrt Tests and changelog entries were added.
Please let me know if you want to do something differently.

@julienrbrt
Copy link
Member

Thanks, could you fix the linting issues?

@MSalopek
Copy link
Contributor Author

MSalopek commented May 9, 2023

Thanks, could you fix the linting issues?

Fixed!

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! However, I do not think we can backport that to v0.47 🤔

@julienrbrt julienrbrt added this pull request to the merge queue May 11, 2023
Merged via the queue into cosmos:main with commit b28c50f May 11, 2023
@julienrbrt
Copy link
Member

Reminder for myself, precise a behavior change in the UPGRADING.md and/or changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AfterUnbondingInitiated can be called with invalid unbondingID
4 participants