Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting the base denom #16257

Merged
merged 6 commits into from
May 23, 2023
Merged

feat: allow setting the base denom #16257

merged 6 commits into from
May 23, 2023

Conversation

emidev98
Copy link
Contributor

Description

Allow changing the default base denom from types with any other previously registered denom.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@emidev98 emidev98 requested a review from a team as a code owner May 23, 2023 07:37
@github-prbot github-prbot requested review from a team, kocubinski and facundomedica and removed request for a team May 23, 2023 07:37
@emidev98 emidev98 changed the title Feature: allow setting the base denom feature: allow setting the base denom May 23, 2023
@emidev98 emidev98 changed the title feature: allow setting the base denom feat: allow setting the base denom May 23, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise lgtm, but I am curious about the use-case of this.
When do you need to change the base denom?

@emidev98
Copy link
Contributor Author

Imagine if you want to register multiple coin denoms to operate with different precision on different applications (while coding for a core module or on cosmwasm smart contract) but you don't want to change the default denom on the unit with more precision (as coded here).

E.g.: when upgrading the core for backwards compatibility, register multiple denoms with precision 10^-3, 10^-6, 10^-9 but use the same old denom with 10^-6 precision.

@emidev98 emidev98 requested a review from julienrbrt May 23, 2023 08:55
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@julienrbrt julienrbrt added this pull request to the merge queue May 23, 2023
Merged via the queue into cosmos:main with commit 995d2bc May 23, 2023
@emidev98 emidev98 deleted the feat/basedenom branch May 24, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants