feat: set default denom #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 78.03% 78.03%
=======================================
Files 4 4
Lines 701 701
=======================================
Hits 547 547
Misses 140 140
Partials 14 14 |
gregnuj
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following bug #136.
There are some commented lines because the default bond denom is always the one with larger decimals precision https://github.com/terra-money/cosmos-sdk/blob/release/v0.45.x/types/denom.go#L27-L29. The idea will be to submit a pull request to CosmoSDK to be able to chose the default denom so the other denoms can be registered later on by just uncommenting the lines (cosmos/cosmos-sdk#16257)