Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: StateSync Restore by excluding memory store #16449

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix: StateSync Restore by excluding memory store #16449

merged 1 commit into from
Jun 7, 2023

Conversation

chillyvee
Copy link
Contributor

@chillyvee chillyvee commented Jun 7, 2023 •
edited
Loading

Description

StateSync restore over p2p network and the new v0.47 local snapshot BOTH FAIL after restore due to AppHash mismatch.

Exclude memory:capability store to follow logic in commitStores()

Reference for proper commit info building:
https://github.com/cosmos/cosmos-sdk/blob/main/store/rootmulti/store.go#L1176

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@chillyvee chillyvee requested a review from a team as a code owner June 7, 2023 22:30
@github-prbot github-prbot requested review from a team, kocubinski and atheeshp and removed request for a team June 7, 2023 22:31
@julienrbrt julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jun 7, 2023
@julienrbrt julienrbrt changed the title Fix StateSync Restore by excluding memory store fix: StateSync Restore by excluding memory store Jun 7, 2023
@chillyvee chillyvee force-pushed the cv_fix_ssync_commit branch from f01057a to f90fe9e Compare June 7, 2023 22:36
@julienrbrt julienrbrt enabled auto-merge June 7, 2023 23:02
@julienrbrt julienrbrt added this pull request to the merge queue Jun 7, 2023
Merged via the queue into cosmos:main with commit d1e685b Jun 7, 2023
mergify bot pushed a commit that referenced this pull request Jun 7, 2023
@chillyvee @mergify
fix: StateSync Restore by excluding memory store (#16449)
3cc3ac7 
(cherry picked from commit d1e685b)
@mergify mergify bot mentioned this pull request Jun 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 7, 2023
@chillyvee @mergify
fix: StateSync Restore by excluding memory store (#16449)
1190282 
(cherry picked from commit d1e685b)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jun 7, 2023
Merged
julienrbrt pushed a commit that referenced this pull request Jun 7, 2023
@mergify @chillyvee
fix: StateSync Restore by excluding memory store (backport #16449) (#…
2100a73 
…16451)

Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
julienrbrt added a commit that referenced this pull request Jun 7, 2023
@mergify @chillyvee @julienrbrt
fix: StateSync Restore by excluding memory store (backport #16449) (#…
3bbc0aa 
…16452)

Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
roy-dydx pushed a commit to dydxprotocol/cosmos-sdk that referenced this pull request Jul 11, 2023
@mergify @chillyvee
@julienrbrt @roy-dydx
fix: StateSync Restore by excluding memory store (backport cosmos#16449…
64dbfe7 
…) (cosmos#16452)

Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
kakysha pushed a commit to InjectiveLabs/cosmos-sdk that referenced this pull request Aug 15, 2023
@mergify @chillyvee
@julienrbrt @kakysha
fix: StateSync Restore by excluding memory store (backport cosmos#16449…
36368cb 
…) (cosmos#16452)

Co-authored-by: Chill Validation <92176880+chillyvee@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski kocubinski is a code owner

@atheeshp atheeshp Awaiting requested review from atheeshp

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillyvee @julienrbrt