feat: add custom max gas for block for sim config #16656

mmsqe · 2023-06-22T13:01:53Z

Description

To avoid sim test fail when check unlimited max gas as invalid consensus params.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

… sim test" This reverts commit 98d8a19.

alexanderbez · 2023-06-22T14:36:19Z

x/simulation/params.go

@@ -176,7 +176,7 @@ func (w WeightedProposalContent) ContentSimulatorFn() simulation.ContentSimulato
 // Consensus Params

 // randomConsensusParams returns random simulation consensus parameters, it extracts the Evidence from the Staking genesis state.
-func randomConsensusParams(r *rand.Rand, appState json.RawMessage, cdc codec.JSONCodec) *cmtproto.ConsensusParams {
+func randomConsensusParams(r *rand.Rand, appState json.RawMessage, cdc codec.JSONCodec, maxGas *int64) *cmtproto.ConsensusParams {


why not just pass -1 to indicate to not override?

alexanderbez · 2023-06-22T14:36:28Z

x/simulation/params.go

@@ -197,7 +197,9 @@ func randomConsensusParams(r *rand.Rand, appState json.RawMessage, cdc codec.JSO
 			MaxAgeDuration:  stakingGenesisState.Params.UnbondingTime,
 		},
 	}
-
+	if maxGas != nil {


Suggested change

if maxGas != nil {

if maxGas > 0 {

seems pointer is easier to understand, since default value of integer is 0, it might be confused to pass -1

Yes, but block max gas semantics are that any non-positive value is indicative of being "set". Why not just stick with that?

alexanderbez · 2023-06-22T14:57:29Z

x/simulation/simulate.go

+	blockMaxGas := int64(-1)
+	if config.BlockMaxGas != nil {
+		blockMaxGas = *config.BlockMaxGas
+	}


The zero value of int64 is 0, but 0 is a valid value for max gas. If we don't use a pointer, we cannot maintain a default behaviour of maxGas with value -1

Why can't the default be -1 w/o using a pointer?

updated, but we can't set maxGas as 0 unless pointer

julienrbrt

lgtm!

odeke-em

Thank you @mmsqe!

x/simulation/params.go

julienrbrt · 2023-06-26T19:35:01Z

CHANGELOG.md

@@ -101,6 +101,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 * (cli) [#16209](https://github.com/cosmos/cosmos-sdk/pull/16209) Make `StartCmd` more customizable.
 * (types) [#16257](https://github.com/cosmos/cosmos-sdk/pull/16257) Allow setting the base denom in the denom registry.
 * (genutil) [#16046](https://github.com/cosmos/cosmos-sdk/pull/16046) Add "module-name" flag to genutil add-genesis-account to enable intializing module accounts at genesis.
+* (sims) [#16656](https://github.com/cosmos/cosmos-sdk/pull/16656) Add custom max gas for block for sim config with unlimited as default.


nit, can you place the changelog under unreleased?

updated, is it possible that we backport to v0.46.x as well

alexanderbez

utACK

(cherry picked from commit 9b2fd7b)

(cherry picked from commit 9b2fd7b) # Conflicts: # x/simulation/params.go

…16729)

…16730) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

…16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

* build(deps): bump cometbft to v0.34.29 (cosmos#16553) * fix(x/auth): ensure nil .BaseAccounts are reported in ModuleAccount.Validate (backport cosmos#16554) (cosmos#16570) Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: snapshotter's failure is not propogated (backport cosmos#16588) (cosmos#16604) Co-authored-by: yihuang <huang@crypto.com> * feat: add custom max gas for block for sim config (backport cosmos#16656) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: accaddr cachefix (backport cosmos#15433) (cosmos#16823) Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: HuangYi <huang@crypto.com> * fix(cli): improve `prune` command ux (backport cosmos#16856) (cosmos#16876) Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: query tx events with `>=` and `<=` operators (cosmos#16994) * docs: change bank multi-send command description (backport cosmos#16950) (cosmos#17019) * chore: prepare v0.46.14 (cosmos#16879) * refactor: add MigrateHandler to allow reuse migrate genesis related function (backport cosmos#17296) (cosmos#17301) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix: resolve migration map in MigrateHandler (cosmos#17301) (cosmos#17302) * feat(x/gov): Emit VoterAddr (backport cosmos#17354) (cosmos#17357) Co-authored-by: Devon Bear <itsdevbear@berachain.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * feat(x/gov): add MsgSubmitProposal SetMsgs method (backport cosmos#17387) (cosmos#17388) Co-authored-by: Julien Robert <julien@rbrt.fr> --------- Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: yihuang <huang@crypto.com> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: KyleMoser <KyleMoser@users.noreply.github.com> Co-authored-by: Rootul P <rootulp@gmail.com> Co-authored-by: Devon Bear <itsdevbear@berachain.com>

) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

github-actions bot added the C:Simulations label Jun 22, 2023

mmsqe added 3 commits June 22, 2023 21:03

avoid invalid consensus params when set unlimited max gas for sim test

98d8a19

Revert "avoid invalid consensus params when set unlimited max gas for…

25790ad

… sim test" This reverts commit 98d8a19.

add custom BlockMaxGas for sim test

00b13c5

mmsqe force-pushed the fix_sim branch from de09f1c to 0e18abb Compare June 22, 2023 13:04

add change doc

741e481

mmsqe force-pushed the fix_sim branch from 0e18abb to 741e481 Compare June 22, 2023 13:05

mmsqe marked this pull request as ready for review June 22, 2023 13:05

mmsqe requested a review from a team as a code owner June 22, 2023 13:05

github-prbot requested review from a team, facundomedica and likhita-809 and removed request for a team June 22, 2023 13:05

tac0turtle approved these changes Jun 22, 2023

View reviewed changes

alexanderbez reviewed Jun 22, 2023

View reviewed changes

julienrbrt added backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jun 22, 2023

fix config

d9337b4

alexanderbez reviewed Jun 22, 2023

View reviewed changes

use 0 as -1

86b7150

julienrbrt approved these changes Jun 23, 2023

View reviewed changes

odeke-em reviewed Jun 25, 2023

View reviewed changes

x/simulation/params.go Outdated Show resolved Hide resolved

mmsqe added 2 commits June 26, 2023 09:06

Merge remote-tracking branch 'origin/main' into fix_sim

e9edb5b

Apply suggestions from code review

80c1415

odeke-em approved these changes Jun 26, 2023

View reviewed changes

julienrbrt reviewed Jun 26, 2023

View reviewed changes

mmsqe added 2 commits June 27, 2023 08:31

Merge remote-tracking branch 'origin/main' into fix_sim

63c3b6c

update change doc

edd55bd

alexanderbez approved these changes Jun 27, 2023

View reviewed changes

julienrbrt added this pull request to the merge queue Jun 27, 2023

julienrbrt added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jun 27, 2023

Merged via the queue into cosmos:main with commit 9b2fd7b Jun 27, 2023

mergify bot pushed a commit that referenced this pull request Jun 27, 2023

feat: add custom max gas for block for sim config (#16656)

e7f1765

(cherry picked from commit 9b2fd7b)

mergify bot pushed a commit that referenced this pull request Jun 27, 2023

feat: add custom max gas for block for sim config (#16656)

163e9d4

(cherry picked from commit 9b2fd7b) # Conflicts: # x/simulation/params.go

mergify bot mentioned this pull request Jun 27, 2023

feat: add custom max gas for block for sim config (backport #16656) #16729

Merged

mergify bot pushed a commit that referenced this pull request Jun 27, 2023

feat: add custom max gas for block for sim config (#16656)

60db788

(cherry picked from commit 9b2fd7b) # Conflicts: # x/simulation/params.go

This was referenced Jun 27, 2023

feat: add custom max gas for block for sim config (backport #16656) #16730

Merged

feat: add custom max gas for block for sim config (backport #16656) #16731

Merged

julienrbrt pushed a commit that referenced this pull request Jun 27, 2023

feat: add custom max gas for block for sim config (backport #16656) (#…

84256a0

…16729)

facundomedica added a commit that referenced this pull request Jun 28, 2023

feat: add custom max gas for block for sim config (backport #16656) (#…

d681010

…16730) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Facundo Medica <facundomedica@gmail.com>

tac0turtle added a commit that referenced this pull request Jun 28, 2023

feat: add custom max gas for block for sim config (backport #16656) (#…

a763135

…16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

GAtom22 pushed a commit to evmos/cosmos-sdk that referenced this pull request Jul 12, 2023

feat: add custom max gas for block for sim config (backport cosmos#16656

41f3d27

) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

GAtom22 pushed a commit to evmos/cosmos-sdk that referenced this pull request Jul 12, 2023

feat: add custom max gas for block for sim config (backport cosmos#16656

9166c32

) (cosmos#16731) Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com>

faddat mentioned this pull request Sep 5, 2023

chore: bump cosmos-sdk terra-money/cosmos-sdk#267

Closed

19 tasks

faddat mentioned this pull request Oct 15, 2023

chore: Merge in upstream v0.46.x celestiaorg/cosmos-sdk#350

Closed

19 tasks

0xstepit mentioned this pull request Jul 1, 2024

chore(cachemulti): add Copy method evmos/cosmos-sdk#52

Merged

faddat mentioned this pull request Nov 8, 2024

faddat/many times #22476

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add custom max gas for block for sim config #16656

feat: add custom max gas for block for sim config #16656

mmsqe commented Jun 22, 2023

alexanderbez Jun 22, 2023

alexanderbez Jun 22, 2023

mmsqe Jun 22, 2023

alexanderbez Jun 22, 2023

alexanderbez Jun 22, 2023

mmsqe Jun 22, 2023

alexanderbez Jun 22, 2023

mmsqe Jun 23, 2023

julienrbrt left a comment

odeke-em left a comment

julienrbrt Jun 26, 2023

mmsqe Jun 27, 2023

alexanderbez left a comment

feat: add custom max gas for block for sim config #16656

feat: add custom max gas for block for sim config #16656

Conversation

mmsqe commented Jun 22, 2023

Description

Author Checklist

Reviewers Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

odeke-em left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment